Path ... tree preview
#737
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous check blocked any path containing '..' anywhere, which caused false positives for legitimate paths like '[...path]' (Next.js catch-all routes). The fix splits the path by '/' and only blocks if a segment starts with '..', which correctly identifies directory traversal attempts while allowing legitimate filenames that contain '..' within them. Co-authored-by: michael <[email protected]>
|
Cursor Agent can help with this pull request. Just |
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix 'Error loading tree preview' for paths containing
...by refining the directory traversal check.The previous check
path.includes('..')was overly broad, preventing legitimate paths like[...path](Next.js catch-all routes) from being viewed. The updated logic now splits the path into segments and only flags a path as invalid if any segment starts with.., effectively preventing directory traversal (../) while allowing..within a filename.Linear Issue: SOU-73